metrics: actually return a 200 status code #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason the page is returning a 404 status code at the moment. I haven't found exactly why, but this forces the status code on that page to be 200 when metrics are returned.
|
Huh. Would've definitely expected 200 to be a default. |
|
er, thought that was a merge button. Anyway, r=me with CI passing |
|
Confirmed it works with this landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason the page is returning a 404 status code at the
moment. I haven't found exactly why, but this forces the status code on
that page to be 200 when metrics are returned.
r? @Mark-Simulacrum