Skip to content

Rename sub menu label containing docs.rs information "docs.rs" #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2025

Conversation

GuillaumeGomez
Copy link
Member

The naming of this sub-menu is kinda unclear and definitely doesn't help finding information about docs.rs. So instead, let's rename it "docs.rs" directly to make it more obvious what it actually contains.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner May 13, 2025 20:56
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label May 13, 2025
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both @Nemo157 and me feel like splitting the menu is better.

  • the first two items are about docs.rs (About, privacy)
  • the rest are other rust things, could still be named "Rust" or something better?

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I like it much more!

The gui-tests need fixing, but then I'll approve & merge

@syphar syphar merged commit 5eb5728 into rust-lang:master May 17, 2025
10 checks passed
@syphar
Copy link
Member

syphar commented May 17, 2025

thanks!

@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels May 17, 2025
@GuillaumeGomez GuillaumeGomez deleted the docs.rs-label branch May 17, 2025 09:45
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants