Skip to content

Get build_package_in_chroot target from metadata.default_target. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

quadrupleslap
Copy link

  • The only test I did was to make sure it built.
  • It silently reverts to the platform native target if...
    • there was an error getting the metadata.
    • the user gave a target that was unsupported.

Again, sorry if this is an incredibly stupid PR and I'm just missing something.

@onur
Copy link
Member

onur commented Feb 8, 2018

Hi @quadrupleslap this is great, thanks for the PR!

But there is a problem. By default (without any target in CompileOptions docs.rs' cargo is building documentation into /home/cratesfyi/cratesfyi. But when you provide some target, it will build into /home/cratesfyi/cratesfyi/{TARGET}. Your patch is working for building non-default target but docs.rs is failing to copy default documentation since it's not available in default location.

But this is right approach and I was exactly thinking the same when I first added Metadata. I'll fix it when I find some time, thanks again!

@quadrupleslap
Copy link
Author

Thank you! I hope you get around to it sometime.

@QuietMisdreavus
Copy link
Member

This looks like it got superseded by #255, so i'm going to close this. If you think that this PR should still be considered, feel free to comment and reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants