fix new clippy warnings #1690
Merged
fix new clippy warnings #1690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
jyn514
reviewed
Feb 26, 2022
| @@ -270,6 +270,7 @@ impl Routes { | |||
| pattern.to_string(), | |||
| Box::new(RequestRecorder::new( | |||
| SimpleRedirect::new(|url| { | |||
| #[allow(clippy::unnecessary_to_owned)] | |||
| url.set_path(&url.path().trim_end_matches('/').to_string()) | |||
There was a problem hiding this comment.
Hmm, why doesn't removing to_string work?
There was a problem hiding this comment.
error[E0502]: cannot borrow `*url` as mutable because it is also borrowed as immutable
--> src/web/routes.rs:273:25
|
273 | url.set_path(&url.path().trim_end_matches('/'))
| ^^^^--------^^----------^^^^^^^^^^^^^^^^^^^^^^^
| | | |
| | | immutable borrow occurs here
| | immutable borrow later used by call
| mutable borrow occurs here
if I'm not missing anything, we cannot get around this, right?
There was a problem hiding this comment.
ah, makes sense - maybe report this upstream to clippy as a bug?
There was a problem hiding this comment.
will do that, when I can use clippy locally again and prepare a proper issue.
( I'm a victim of rust-lang/rust-clippy#8470 )
jyn514
approved these changes
Feb 26, 2022
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.