Skip to content

Distinguish between time used to read the index and time used to fetch from s3 #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2021
Merged

Distinguish between time used to read the index and time used to fetch from s3 #1534

merged 1 commit into from
Oct 27, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Oct 27, 2021

Helps with #1528.

r? @syphar

@jyn514 jyn514 force-pushed the track-index-time branch 2 times, most recently from d7c236c to 128446b Compare October 27, 2021 09:59
syphar
syphar reviewed Oct 27, 2021
View reviewed changes
@jyn514 jyn514 added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Oct 27, 2021
syphar
syphar approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it feels strange to me to have web-metrics being used in the storage module,

but I right now I prefer having detailed statistics earlier so I know if we still have a problem with the index :)

@jyn514 jyn514 merged commit 5810b01 into rust-lang:master Oct 27, 2021
@jyn514 jyn514 deleted the track-index-time branch October 27, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyn514 @syphar