-
Notifications
You must be signed in to change notification settings - Fork 649
Add versions.edition
column to the database and expose it on the API
#9932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9932 +/- ##
==========================================
+ Coverage 89.18% 89.19% +0.01%
==========================================
Files 294 295 +1
Lines 30713 30753 +40
==========================================
+ Hits 27390 27429 +39
- Misses 3323 3324 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
52eb9cb
to
2577756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Note that this does not include any backfilling for previously uploaded crates. Should we move the API part to a dedicated PR and merge it only after we have backfilled the data?
Your call, but I feel like we can merge this as-is and just not tell anyone until the backfill has occurred. 🙂
2577756
to
934d3fb
Compare
the backfill has occurred 😉 the script to generate the backfill data is available at https://github.com/Turbo87/crates.io/blob/backfill/edition/src/bin/backfill-edition.rs |
This addresses part of #1541 by reading the
edition
field of uploadedCargo.toml
files, saving the value in the database and then exposing it on the API.Note that this does not include any backfilling for previously uploaded crates. Should we move the API part to a dedicated PR and merge it only after we have backfilled the data?
Related:
as_str()
fn LukeMathWalker/cargo-manifest#58