tests/unhealthy_database: Migrate from sync to async database pools #8441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
All of the API endpoints in these tests are using the async database pools at this point, so waiting until the *sync* connection pools are healthy again isn't particularly helpful :D
Turbo87
force-pushed
the
unhealthy-deadpool
branch
from
1b1e7f1 to
740caac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8441 +/- ##
==========================================
- Coverage 87.58% 87.58% -0.01%
==========================================
Files 272 272
Lines 26333 26330 -3
==========================================
- Hits 23065 23061 -4
- Misses 3268 3269 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the API endpoints in these tests are using the async database pools at this point, so waiting until the sync connection pools are healthy again isn't particularly helpful :D