Skip to content

Add support for mermaid diagrams in README files #6587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/components/rendered-html.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@
This component renders raw HTML. Be very careful with this since it
can enable cross-site scripting attacks!
--}}
<div local-class="wrapper" ...attributes {{highlight-syntax selector="pre > code"}}>
<div
local-class="wrapper"
...attributes
{{highlight-syntax selector="pre > code"}}
{{render-mermaids}}
>
{{html-safe @html}}
</div>
12 changes: 12 additions & 0 deletions app/controllers/crate/version.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { task } from 'ember-concurrency';
import { alias } from 'macro-decorators';

export default class CrateVersionController extends Controller {
@service mermaid;
@service session;

get downloadsContext() {
Expand Down Expand Up @@ -41,6 +42,17 @@ export default class CrateVersionController extends Controller {
? version.loadReadmeTask.lastSuccessful.value
: await version.loadReadmeTask.perform();

// If the README contains `language-mermaid` we ensure that the `mermaid` library has loaded before we continue
if (readme.includes('language-mermaid') && !this.mermaid.loadTask.lastSuccessful?.value) {
try {
await this.mermaid.loadTask.perform();
} catch (error) {
// If we failed to load the library due to network issues, it is not the end of the world, and we just log
// the error to the console.
console.error(error);
}
}

if (typeof document !== 'undefined') {
setTimeout(() => {
let e = document.createEvent('CustomEvent');
Expand Down
27 changes: 27 additions & 0 deletions app/modifiers/render-mermaids.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { inject as service } from '@ember/service';
import { waitForPromise } from '@ember/test-waiters';

import Modifier from 'ember-modifier';

export default class ScrollPositionModifier extends Modifier {
@service notifications;
@service mermaid;

modify(element) {
// If the `mermaid` library is loaded (which should have happend in the controller)
let mermaid = this.mermaid.loadTask.lastSuccessful?.value;
if (mermaid) {
// ... find any relevant code snippets
let nodes = element.querySelectorAll('.language-mermaid');

// ... and render them as diagrams
waitForPromise(mermaid.run({ nodes })).catch(error => {
// Log errors to the console
console.error(error.error || error);

// ... and report them as warnings to the user
this.notifications.warning('Failed to render mermaid diagram.');
});
}
}
}
3 changes: 2 additions & 1 deletion app/routes/crate/version.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';
import { waitForPromise } from '@ember/test-waiters';

import { didCancel } from 'ember-concurrency';

Expand Down Expand Up @@ -39,7 +40,7 @@ export default class VersionRoute extends Route {
setupController(controller, model) {
super.setupController(...arguments);

controller.loadReadmeTask.perform().catch(() => {
waitForPromise(controller.loadReadmeTask.perform()).catch(() => {
// ignored
});

Expand Down
11 changes: 11 additions & 0 deletions app/services/mermaid.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import Service from '@ember/service';

import { dropTask } from 'ember-concurrency';

export default class MermaidService extends Service {
loadTask = dropTask(async () => {
let { default: mermaid } = await import('mermaid');
mermaid.initialize({ startOnLoad: false, securityLevel: 'sandbox' });
return mermaid;
});
}
12 changes: 12 additions & 0 deletions crates_io_markdown/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ impl<'a> MarkdownRenderer<'a> {
"language-javascript",
"language-json",
"language-markup",
"language-mermaid",
"language-protobuf",
"language-ruby",
"language-rust",
Expand Down Expand Up @@ -367,6 +368,17 @@ mod tests {
assert!(result.contains("<code class=\"language-rust\">"));
}

#[test]
fn code_block_with_mermaid_highlighting() {
let code_block = r#"```mermaid \
graph LR \
A --> C \
C --> A \
```"#;
let result = markdown_to_html(code_block, None, "");
assert!(result.contains("<code class=\"language-mermaid\">"));
}

#[test]
fn code_block_with_syntax_highlighting_even_if_annot_has_no_run() {
let code_block = r#"```rust , no_run \
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"fastboot-app-server": "4.1.1",
"highlight.js": "11.8.0",
"macro-decorators": "0.1.2",
"mermaid": "10.2.3",
"morgan": "1.10.0",
"pretty-bytes": "6.1.0",
"semver": "7.5.2",
Expand Down
Loading