Skip to content

Replace "Toggle Design" button with new /settings/appearance route #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 31, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 26, 2021

Just like the "Toggle Design" button before, this route is only visible in development mode, or to be more precise: the link to this route is only visible in development mode, so that we can test this out in production too.

This should be seen as a first step towards implementing a "dark color scheme" mode (see #3585), roughly inspired by how GitHub has implemented it in their user settings.

Bildschirmfoto 2021-12-26 um 19 34 12

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Dec 26, 2021
@Turbo87 Turbo87 force-pushed the appearance-settings branch 2 times, most recently from f7e7d99 to 5132ae3 Compare December 26, 2021 20:14
@Turbo87 Turbo87 force-pushed the appearance-settings branch from 5132ae3 to 48b5e14 Compare December 29, 2021 17:20
@Turbo87
Copy link
Member Author

Turbo87 commented Dec 31, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Dec 31, 2021

📌 Commit 48b5e14 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Dec 31, 2021

⌛ Testing commit 48b5e14 with merge 1f18bf7...

@bors
Copy link
Contributor

bors commented Dec 31, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing 1f18bf7 to master...

@bors bors merged commit 1f18bf7 into rust-lang:master Dec 31, 2021
@Turbo87 Turbo87 deleted the appearance-settings branch December 31, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants