Add backend proxy to aid local fastboot testing #2215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @smarnach (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #2389) made this pull request unmergeable. Please resolve the merge conflicts. |
To avoid the need to set up a local nginx configuration during development, this commit adds a simple proxy for frontend requests when `USE_FASTBOOT=staging-experimental` is set. When enabled, developers should browse to http://localhost:8888/ (instead of port 4200 when using `npm run start:local`).
jtgeibel
force-pushed
the
backend-fastboot-proxy
branch
from
268b2c6 to
c9b9ef0
Compare
|
I've rebased onto the new http types, which simplified this logic a lot. This is still intended for local development only. r? @JohnTitor |
|
@bors: r+ |
|
📌 Commit c9b9ef0 has been approved by |
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the need to set up a local nginx configuration during
development, this commit adds a simple proxy for frontend requests when
USE_FASTBOOT=staging-experimentalis set.When enabled, developers should browse to http://localhost:8888/
(instead of port 4200 when using
npm run start:local).