Increase background job timeout for tests #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intermittent errors on GH Actions appear to be coming from two places ([1], [2]) related to running background jobs. It's possible we're hitting the 1 second [timeout] and that the background job is not completing in time. Refs: rust-lang#2059 [1]: https://github.com/rust-lang/crates.io/blob/e74de84f3d69dd623a83dfc0d8b43191e064104d/src/tests/util.rs#L76 [2]: https://github.com/rust-lang/crates.io/blob/e74de84f3d69dd623a83dfc0d8b43191e064104d/src/tests/util.rs#L190 [timeout]: https://github.com/rust-lang/crates.io/blob/e74de84f3d69dd623a83dfc0d8b43191e064104d/src/tests/util.rs#L236
|
@bors r+ |
|
📌 Commit 8e53d59 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 25, 2019
…, r=jtgeibel Increase background job timeout for tests The intermittent errors on GH Actions appear to be coming from two places ([1], [2]) related to running background jobs. It's possible we're hitting the 1 second [timeout] and that the background job is not completing in time. Refs: #2059 r? @carols10cents [1]: https://github.com/rust-lang/crates.io/blob/e74de84f3d69dd623a83dfc0d8b43191e064104d/src/tests/util.rs#L76 [2]: https://github.com/rust-lang/crates.io/blob/e74de84f3d69dd623a83dfc0d8b43191e064104d/src/tests/util.rs#L190 [timeout]: https://github.com/rust-lang/crates.io/blob/e74de84f3d69dd623a83dfc0d8b43191e064104d/src/tests/util.rs#L236
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intermittent errors on GH Actions appear to be coming from two
places (1, 2) related to running background jobs. It's possible
we're hitting the 1 second timeout and that the background job is not
completing in time.
Refs: #2059
r? @carols10cents