Disable application-template-wrapper feature
#2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #2049) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #2053) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
|
📌 Commit 0efc422 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 25, 2019
Disable `application-template-wrapper` feature This is one of the requirements to enable the "Octane" mode of Ember.js. It moves the implicit application template wrapper element into the `application` template and thus makes it optional for those applications that don't need it. Since we set a max width on this element we do currently still need it though. r? @locks
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the requirements to enable the "Octane" mode of Ember.js. It moves the implicit application template wrapper element into the
applicationtemplate and thus makes it optional for those applications that don't need it. Since we set a max width on this element we do currently still need it though.r? @locks