Skip to content

Limit the branches that travis builds on #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

carols10cents
Copy link
Member

Because branches that become PRs are built twice :(

Because branches that become PRs are built twice :(
@rust-highfive
Copy link

r? @smarnach

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

branches:
only:
- auto
- try
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this branch? We don't currently seem to have a branch with this name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used when you do @bors try.

@carols10cents
Copy link
Member Author

@bors r=@smarnach

@bors
Copy link
Contributor

bors commented Dec 18, 2019

📌 Commit fcee1b2 has been approved by smarnach

Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jtgeibel
Copy link
Member

I saw it mentioned somewhere that we don't need to run tests on master, so I wanted to mention that we do want to continue building on master because Travis uses the "default branch" (docs) as the fallback cache for new branches and PRs. I don't see any UI for this in the Travis settings, and I don't think it makes sense to switch HEAD to point to auto instead of master on GitHub.

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 19, 2019

📌 Commit fcee1b2 has been approved by jtgeibel

@carols10cents
Copy link
Member Author

@bors retry

@smarnach
Copy link
Contributor

Have we reached some quota limit for Travis builds? This didn't even start building on Travis yet, same for #1929.

@Turbo87
Copy link
Member

Turbo87 commented Dec 19, 2019

@smarnach I'm not sure if it's on the TravisCI side since the PR jobs for Travis seem to run fine. does @bors have some sort of quota limit? 🤔

@Turbo87
Copy link
Member

Turbo87 commented Dec 19, 2019

hmm, or @bors can run X number of jobs in parallel and the jobs that "timed out" are still running and blocking new jobs from being accepted 🤔

bors added a commit that referenced this pull request Dec 19, 2019
Limit the branches that travis builds on

Because branches that become PRs are built twice :(
@bors
Copy link
Contributor

bors commented Dec 19, 2019

⌛ Testing commit fcee1b2 with merge 41d49ee...

@bors
Copy link
Contributor

bors commented Dec 19, 2019

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing 41d49ee to master...

@bors bors merged commit fcee1b2 into rust-lang:master Dec 19, 2019
@carols10cents carols10cents deleted the limit-travis-to-prs branch December 19, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants