Ammonia 3.0 upgrade #1876
Ammonia 3.0 upgrade #1876
Conversation
Crates.io has only the input tag as an added tag other than the default ones from ammonia. So adding only that one.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @carols10cents (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks for the pull request! Could you also look into the list of tag attributes? The motivating bug was that we did not allow some attributes that are relevant for table layout, but there are more attributes that we could safely allow. |
|
Of course! Will do that later today 😄 |
There was a problem hiding this comment.
@AZanellato it looks like you can completely drop the assignment to tag_attributes now that it is no longer used. Other than that, I think this should be good to go.
|
@jtgeibel done! :) |
|
r? @smarnach |
|
@bors r+ |
|
📌 Commit 6df0cfd has been approved by |
Ammonia 3.0 upgrade Closes #1872. I have followed the instructions on the issue. Basically removing that list of allowed elements and relying on ammonia to do the job and also upgrading ammonia to 3.0.
|
💔 Test failed - checks-travis |
|
@bors retry |
Ammonia 3.0 upgrade Closes #1872. I have followed the instructions on the issue. Basically removing that list of allowed elements and relying on ammonia to do the job and also upgrading ammonia to 3.0.
|
💔 Test failed - checks-travis |
|
@bors retry
…On Tue, 29 Oct 2019, 17:09 bors, ***@***.***> wrote:
💔 Test failed - checks-travis
<https://travis-ci.com/rust-lang/crates.io/builds/134033846>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1876?email_source=notifications&email_token=AAB423AKR2QJVNH5RUAL4RLQRBN3LA5CNFSM4JDKILT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRDJHI#issuecomment-547501213>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB423EALPLH3CQSVA6QJW3QRBN3LANCNFSM4JDKILTQ>
.
|
Ammonia 3.0 upgrade Closes #1872. I have followed the instructions on the issue. Basically removing that list of allowed elements and relying on ammonia to do the job and also upgrading ammonia to 3.0.
|
☀️ Test successful - checks-travis |
Closes #1872.
I have followed the instructions on the issue. Basically removing that list of allowed elements and relying on ammonia to do the job and also upgrading ammonia to 3.0.