Skip to content

Add "Delete this crate" button to the crate settings page #10343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/styles/crate/settings.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,7 @@
.remove-button {
composes: small yellow-button from '../shared/buttons.module.css';
}

.delete-button {
composes: red-button from '../shared/buttons.module.css';
}
8 changes: 8 additions & 0 deletions app/templates/crate/settings.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,11 @@
</div>
{{/each}}
</div>

<h2>Danger Zone</h2>

<div>
<LinkTo @route="crate.delete" local-class="delete-button" data-test-delete-button>
Delete this crate
</LinkTo>
</div>
39 changes: 39 additions & 0 deletions e2e/acceptance/crate-deletion.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
import { expect, test } from '@/e2e/helper';

test.describe('Acceptance | crate deletion', { tag: '@acceptance' }, () => {
test('happy path', async ({ page, mirage }) => {
await mirage.addHook(server => {
let user = server.create('user');
authenticateAs(user);

let crate = server.create('crate', { name: 'foo' });
server.create('version', { crate });
server.create('crate-ownership', { crate, user });
});

await page.goto('/crates/foo');
await expect(page).toHaveURL('/crates/foo');
await expect(page.locator('[data-test-settings-tab] a')).toBeVisible();

await page.click('[data-test-settings-tab] a');
await expect(page).toHaveURL('/crates/foo/settings');
await expect(page.locator('[data-test-delete-button]')).toBeVisible();

await page.click('[data-test-delete-button]');
await expect(page).toHaveURL('/crates/foo/delete');
await expect(page.locator('[data-test-title]')).toHaveText('Delete the foo crate?');
await expect(page.locator('[data-test-delete-button]')).toBeDisabled();

await page.click('[data-test-confirmation-checkbox]');
await expect(page.locator('[data-test-delete-button]')).toBeEnabled();

await page.click('[data-test-delete-button]');
await expect(page).toHaveURL('/');

let message = 'Crate foo has been successfully deleted.';
await expect(page.locator('[data-test-notification-message="success"]')).toHaveText(message);

let crate = await page.evaluate(() => server.schema.crates.findBy({ name: 'foo' }));
expect(crate).toBeNull();
});
});
44 changes: 44 additions & 0 deletions tests/acceptance/crate-deletion-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { click, currentURL } from '@ember/test-helpers';
import { module, test } from 'qunit';

import { setupApplicationTest } from 'crates-io/tests/helpers';

import { visit } from '../helpers/visit-ignoring-abort';

module('Acceptance | crate deletion', function (hooks) {
setupApplicationTest(hooks);

test('happy path', async function (assert) {
let user = this.server.create('user');
this.authenticateAs(user);

let crate = this.server.create('crate', { name: 'foo' });
this.server.create('version', { crate });
this.server.create('crate-ownership', { crate, user });

await visit('/crates/foo');
assert.strictEqual(currentURL(), '/crates/foo');
assert.dom('[data-test-settings-tab] a').exists();

await click('[data-test-settings-tab] a');
assert.strictEqual(currentURL(), '/crates/foo/settings');
assert.dom('[data-test-delete-button]').exists();

await click('[data-test-delete-button]');
assert.strictEqual(currentURL(), '/crates/foo/delete');
assert.dom('[data-test-title]').hasText('Delete the foo crate?');
assert.dom('[data-test-delete-button]').isDisabled();

await click('[data-test-confirmation-checkbox]');
assert.dom('[data-test-delete-button]').isEnabled();

await click('[data-test-delete-button]');
assert.strictEqual(currentURL(), '/');

let message = 'Crate foo has been successfully deleted.';
assert.dom('[data-test-notification-message="success"]').hasText(message);

crate = this.server.schema.crates.findBy({ name: 'foo' });
assert.strictEqual(crate, null);
});
});
Loading