Fix some clippy lints #8878
Closed
Fix some clippy lints #8878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit can be replicated with `cargo +nightly clippy -Z unstable-options --fix`.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Eh2406
reviewed
Nov 22, 2020
src/cargo/util/errors.rs
Outdated
| @@ -470,7 +470,7 @@ pub fn is_simple_exit_code(code: i32) -> bool { | |||
| // codes are very large. This is just a rough | |||
| // approximation of which codes are "normal" and which | |||
| // ones are abnormal termination. | |||
| code >= 0 && code <= 127 | |||
| (0..=127).contains(&code) | |||
There was a problem hiding this comment.
I think @ehuss has been against this one in the past.
There was a problem hiding this comment.
Ok, I reverted the change.
| (Definition::Environment(_), Definition::Path(_)) => true, | ||
| _ => false, | ||
| } | ||
| matches!((self, other), (Definition::Cli, Definition::Environment(_)) | (Definition::Cli, Definition::Path(_)) | (Definition::Environment(_), Definition::Path(_))) |
There was a problem hiding this comment.
This came up previously, but I don't think this change should be made.
| Some(libc::ENOSYS) => true, | ||
| _ => false, | ||
| } | ||
| matches!(err.raw_os_error(), Some(libc::ENOTSUP) | Some(libc::ENOSYS)) |
There was a problem hiding this comment.
I believe the meaning here has changed? The ENOSYS arm is no longer just on Linux.
| @@ -22,7 +22,7 @@ fn get_available_targets<'a>( | |||
| .map(Target::name) | |||
| .collect(); | |||
|
|
|||
| targets.sort(); | |||
| targets.sort_unstable(); | |||
There was a problem hiding this comment.
This also came up previously and I don't think this change should be made.
|
Oh I missed #8831, sorry. Probably that should take precedence over this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit can be replicated with
cargo +nightly clippy -Z unstable-options --fix.I am totally ambivalent as to whether this lands, if you want to close it because you don't like clippy that's fine by me.