[WIP] feat(manifest): add a force-frame-pointers profile option
#15451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-build-execution
epage
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Some of the solution details are still being discussed in #15451
epage
reviewed
Apr 23, 2025
Comment on lines
+707
to
+708
| #[cargo_test] | ||
| fn force_frame_pointers_on_works() { |
There was a problem hiding this comment.
Would you be up for putting the tests in a previous commit without force-frame-pointers, having them pass, showing the existing behavior? Then in this commit, the diff highlights the new feature and what it changes
There was a problem hiding this comment.
No problem, I can do that
There was a problem hiding this comment.
EDIT : I suppose I should first wait for a conclusion to the conversation in the related issue ?
brvtalcake
changed the title
force-frame-pointers profile optionforce-frame-pointers profile option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This PR resolves #15333, and a
force-frame-pointersoption for profiles. It also fixes tests related to profiles, and adds some basic tests for the new option itself.How should we test and review this PR?
Run the tests in
tests/testsuite/profiles.rs:force_frame_pointers_on_worksforce_frame_pointers_off_worksforce_frame_pointers_unspecified_worksAdditional information
See, however, the discussion in the linked issue, as there might be some changes needed