Convert to default installation of cargo and replace --with-cargo option with --without-cargo option
#98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but I wonder if we do want a |
Anyone opposed to this? I'll add it this weekend if this is the only thing blocking the merge here. |
chrissimpkins
changed the title
--with-cargo option--with-cargo option
chrissimpkins
force-pushed
the
cargo-default
branch
from
afbdffb to
c5e86ee
Compare
|
Rebased on master @ c5e86ee |
chrissimpkins
changed the title
--with-cargo option--with-cargo option with --without-cargo option
|
|
|
@spastorino Please let me know if there is anything else that you need for this PR. Thanks Santiago! |
chrissimpkins
commented
Jul 5, 2020
| if dl_params.install_cargo { | ||
| // download cargo by default | ||
| // deactivate with the `--without-cargo` flag | ||
| // this default behavior was changed as of v0.6.0 |
There was a problem hiding this comment.
This line assumes a v0.6.0 release with the current changes if this PR is acceptable.
This was referenced Oct 21, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Also see the discussion in https://rust-lang.zulipchat.com/#narrow/stream/217417-t-compiler.2Fcargo-bisect-rustc/topic/unrecognized.20option.20json
This PR converts the
--with-cargooptional behavior to default behavior to addressUnrecognized option: 'json'errors in tests as bisection proceeds back in time past a defined date (I believe that this is ~ July 2019'ish era). The current default leads to incorrect automated detection of the regression commit due to this error. These changes also remove the--with-cargooption.Edit: @spastorino recommended the addition of the
--without-cargoflag to disable the cargo install in #98 (comment). This change was added in 2b7088c