-
Notifications
You must be signed in to change notification settings - Fork 300
Add post about changes to x.py defaults #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e8f47da
Add x.py post
jyn514 bbe45ab
rustc is a program, so it should be rendered as code
jyn514 2f7de90
Improve wording
jyn514 9b770da
Mention what `build` does, not just what it doesn't do
jyn514 c3df59b
Add a short rationale for the changes
jyn514 cf91f1f
Improve wording
jyn514 0e43687
Highlight `x.py` as code
jyn514 5a87a5a
Improve wording
jyn514 29eef78
libstd was built three times, not rustc
jyn514 1afb969
Update the filename with the current date
jyn514 91b2629
'stage 2 libstd' is just a copy of stage 1
jyn514 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
layout: post | ||
title: "Changes to x.py defaults" | ||
author: Joshua Nelson | ||
team: the compiler team <https://www.rust-lang.org/governance/teams/compiler> | ||
--- | ||
|
||
Recently, the defaults for [x.py] - the tool used to [bootstrap] the rust compiler from source - changed. If you regularly contribute to the rust compiler, this might affect your workflow. | ||
jyn514 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## What changes were made? | ||
|
||
- The default stage is now dependent on the subcommand. | ||
jyn514 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
+ `dist`: stage 2 | ||
+ `build`: stage 1 | ||
+ `test`: stage 1 | ||
+ `doc`: stage 0 | ||
|
||
- stage1 rustc artifacts are no longer built by `x.py build --stage 1`. To get the old behavior back, use `x.py build --stage 1 src/rustc`. | ||
jyn514 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- `debuginfo` now defaults to `1` when `debug = true`. Previously, the default was 2. | ||
|
||
## Why were the changes made? | ||
|
||
For a detailed rationale of the changes, as well as more information about the alternatives considered, see | ||
jyn514 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- [the MCP] | ||
- the [implementation PR] | ||
- the [Zulip stream] | ||
|
||
[x.py]: https://rustc-dev-guide.rust-lang.org/building/how-to-build-and-run.html#what-is-xpy | ||
jyn514 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
[bootstrap]: https://rustc-dev-guide.rust-lang.org/building/bootstrapping.html | ||
[the MCP]: https://github.com/rust-lang/compiler-team/issues/326 | ||
[implementation PR]: https://github.com/rust-lang/rust/pull/73964 | ||
[Zulip stream]: https://rust-lang.zulipchat.com/#narrow/stream/233931-xxx/topic/Use.20sane.20defaults.20in.20x.py.20compiler-team.23326 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.