Line spacing?

[steveklabnik]

from https://news.ycombinator.com/item?id=17980163 and https://www.reddit.com/r/rust/comments/9fjn8e/announcing_rust_129/e5wxixx/

@jonhoo , this is due to your tweaks here: #263

any idea how we should fix this?

I've reverted those changes until we can sort this.

[jonhoo]

That's really weird -- it looks fine here too. This suggests there's a line-height property somewhere that's affecting the code samples, but I can't find one in our code. When line-height isn't set, underscores and the like should render just fine. It's a little hard to debug this now that it's been reverted. The quick-fix would be to add line-height: 1.5 to the pre, code rule in _sass/_base.css.

[reiner-dolp]

I think the core problem here is that background-color is set on pre code, because you are using the same style for <code> and <pre> tags. Highlighted differently for explanation:

Removing the background color from all code tags inside a pre tag will resolve the issue.

Demonstration of bug by narrowing line height:

Overdoing it for demonstration:

Bug fixed with transparent background on pre code:

[jonhoo]

Interesting.. I don't see how that'd cause the underscore to become invisible, but it's a worthwhile thing to try. Just put background-color only on pre (not code), and keep the patch otherwise the way it was, and it should be good.

[reiner-dolp]

@jonhoo I have added additional screenshots for explanation. Lines are rendered one after another. If the line-spacing becomes to tight the background of the current line will hide the bottom of the previous line (especially since the background is extended using a padding of 1px in height), which in our case hides the underscore.

I think #269 can be reapplied with an additional background: transparent; after line 143 in _base.css.