Skip to content

track_caller for zip_eq #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dspyz-matician
Copy link

@dspyz-matician dspyz-matician commented May 24, 2025

This is expected to panic on length mismatch

Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.26%. Comparing base (6814180) to head (a4622ae).
Report is 141 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   94.38%   94.26%   -0.13%     
==========================================
  Files          48       50       +2     
  Lines        6665     6193     -472     
==========================================
- Hits         6291     5838     -453     
+ Misses        374      355      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phimuemue
Copy link
Member

Hi there, thanks for this.

@jswrenn I'm torn on this one: That track_caller is nice, but it does afaik not reliably catch all notable places: Here, we would "fix" next, but all functions calling next would still be unsolved. Thus, I'm unsure if we should start adopting this feature in itertools, especially if there are many places where its use is debatable.

@dspyz-matician
Copy link
Author

It's an improvement but not a perfect fix. #[track_caller] is always a matter of best effort and it's not terrible when it fails to pinpoint the source of a bug, but it's useful when it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants