Add support for building the e310x crate #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for architectures that prefer dispatching interrupts in software.
This was referenced Mar 3, 2018
|
Hey @dvc94ch, it looks generally good to me, would you mind adding some good RISC-V examples (or at least the e310x svd) to the regression tests? Check out Once you do that, I can trigger CI and LGTM. |
|
@jamesmunns Thank you for the quick review! I won't get around to it till tomorrow. Found some time today after all... |
|
Thanks! Lets see how CI goes. bors r+ |
Timed out |
|
I'm getting permission denied when I click the red cross [0], can you post a log? |
|
All tests passed so merging manually. I'll increase the timeout from 1 hour to 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.