optimize the codegen of Vec::clone #290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes optimize
Vec<u8, 1024>::clone
down to these operationslen
fieldlen
bytes of data from the parentanalyzed source code
machine code with
lto = fat
,codegen-units = 1
andopt-level = 'z'
('z' instead of 3 to avoid loop unrolling and keep the machine code readable)note that it's not optimizing step (3) to an actual
memcpy
because we lack the 'trait specialization' code that libstd usesbefore
clone
was optimized tomemclr
) 1028 (!?) bytes of stack spacelen
is equal or less than 1024 (capacity) -- this included a panicking branchlen
bytes of data from the parent