async/spi: add helper methods to SpiDevice. #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to add them as default methods to `SpiDevice` itself, but it's possible to do via an extension trait! With this, you can avoid interacting with the horrible async closure hack in most cases. You can now do `my_device.write(&buf).await`, just like with bare buses.
|
r? @eldruin (rust-highfive has picked a reviewer for you, use r? to override) |
eldruin
reviewed
Mar 11, 2022
|
Yes. Actually, all SpiDeviceExt impl downstream will conflict with the one in this crate. It's impossible to impl That's exactly what we want though. Downstream is supposed to impl just SpiDevice. That makes |
|
oooh, looks neat! (gosh i can't wait for actual async traits 😂) |
eldruin
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to add them as default methods to
SpiDeviceitself,but it's possible to do via an extension trait!
With this, you can avoid interacting with the horrible async closure hack in most
cases. You can now do
my_device.write(&buf).await, just like with bare buses.