Skip to content

check-blobs.sh does nothing #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonas-schievink opened this issue Aug 17, 2020 · 1 comment · Fixed by #259
Closed

check-blobs.sh does nothing #254

jonas-schievink opened this issue Aug 17, 2020 · 1 comment · Fixed by #259
Labels
bug

Comments

@jonas-schievink
Copy link
Contributor

Running it modifies all the archives on my system, but doesn't fail.

Since we've started passing -g to the assembler, all files now contain system-specific paths and are not reproducible.
@adamgreig
Copy link
Member

check-blobs.sh compares the output of arm-none-eabi-objdump -Cd, which does not contain the system-specific paths and the CI seems to be correctly checking that those outputs match, but unfortunately that's not the same as checking the actual .a files match byte-for-byte. Can we specify -g without causing specific paths to be included?

@jonas-schievink jonas-schievink mentioned this issue Aug 18, 2020
Merged
bors bot added a commit that referenced this issue Aug 18, 2020
@bors @jonas-schievink
Merge #255
d57bff9 
255: Remap debuginfo paths r=therealprof a=jonas-schievink

cc #254

Co-authored-by: Jonas Schievink <[email protected]>
@jonas-schievink jonas-schievink mentioned this issue Aug 25, 2020
Merged
@bors bors bot closed this as completed in 36886f1 Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rust assembly stubs
2 participants
@adamgreig @jonas-schievink