-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add loongarch64 musllinux_1_2 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: 吴小白 <[email protected]>
af931ae
to
db2b3cc
Compare
Signed-off-by: 吴小白 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we should also update https://github.com/rust-cross/manylinux-cross/blob/main/render.py to include the new targets (and some others we forget to add to it).
cce3acd
to
66dbb98
Compare
Dockerfile.j2
Outdated
ENV CARGO_BUILD_TARGET={{ target | replace('ibm', 'unknown') | replace('riscv64', 'riscv64gc') }} | ||
ENV CARGO_TARGET_{{ target | replace('ibm', 'unknown') | replace('-', '_') | replace('riscv64', 'riscv64gc') | upper }}_LINKER={{ target }}-gcc | ||
{% if platform.startswith('musllinux') -%} | ||
ENV CARGO_TARGET_{{ target | replace('ibm', 'unknown') | replace('-', '_') | upper }}_RUSTFLAGS='-C target-feature=+crt-static' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://peps.python.org/pep-0656/#rationale
The musllinux platform tags only apply to Python interpreters dynamically linked against the musl libc and executed on the runtime shared library, on a Linux operating system. Statically linked interpreters or mixed builds with other libc implementations (such as glibc) are out of scope and not supported by platform tags defined in this document. Such interpreters should not claim compatibility with musllinux platform tags.
I don't think we should static link musl libc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let me fix that.
Signed-off-by: 吴小白 <[email protected]>
I tested and it works.