Skip to content

Add loongarch64 musllinux_1_2 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

Add loongarch64 musllinux_1_2 #109

merged 3 commits into from
May 20, 2025

Conversation

wojiushixiaobai
Copy link
Contributor

@wojiushixiaobai wojiushixiaobai requested a review from messense as a code owner May 17, 2025 05:47
@wojiushixiaobai wojiushixiaobai force-pushed the main branch 3 times, most recently from af931ae to db2b3cc Compare May 17, 2025 06:45
Signed-off-by: 吴小白 <[email protected]>
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we should also update https://github.com/rust-cross/manylinux-cross/blob/main/render.py to include the new targets (and some others we forget to add to it).

@wojiushixiaobai
Copy link
Contributor Author

wojiushixiaobai commented May 17, 2025

@wojiushixiaobai wojiushixiaobai force-pushed the main branch 2 times, most recently from cce3acd to 66dbb98 Compare May 17, 2025 12:27
Dockerfile.j2 Outdated
ENV CARGO_BUILD_TARGET={{ target | replace('ibm', 'unknown') | replace('riscv64', 'riscv64gc') }}
ENV CARGO_TARGET_{{ target | replace('ibm', 'unknown') | replace('-', '_') | replace('riscv64', 'riscv64gc') | upper }}_LINKER={{ target }}-gcc
{% if platform.startswith('musllinux') -%}
ENV CARGO_TARGET_{{ target | replace('ibm', 'unknown') | replace('-', '_') | upper }}_RUSTFLAGS='-C target-feature=+crt-static'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://peps.python.org/pep-0656/#rationale

The musllinux platform tags only apply to Python interpreters dynamically linked against the musl libc and executed on the runtime shared library, on a Linux operating system. Statically linked interpreters or mixed builds with other libc implementations (such as glibc) are out of scope and not supported by platform tags defined in this document. Such interpreters should not claim compatibility with musllinux platform tags.

I don't think we should static link musl libc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me fix that.

Signed-off-by: 吴小白 <[email protected]>
@messense messense merged commit d1d6262 into rust-cross:main May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants