Skip to content

Planning module: Missing varint length in size calculation of some placeholders #771

Open
@jp1ac4

Description

@jp1ac4

As mentioned in #481 (comment), it appears that the planning module doesn't include the varint length for TapScript and TapControlBlock when getting the size, but does for other placeholders:

Placeholder::TapScript(s) => s.len(),
Placeholder::TapControlBlock(cb) => cb.serialize().len(),

Should the varint length be included here for consistency with other placeholders?

Please also see #701 for some other inconsistencies.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions