Skip to content

types: model types shouldn't have signed values unless its meaningful - I think #238

Open
@tcharding

Description

@tcharding

We overuse signed ints because it was found in the wild that Core has a tendency to return -1. However in model I don't think we should have signed ints unless its meaningful.

Found while reviewing #237 and also on master we have in model::wallet::GetTransaction:

    pub confirmations: i64, // Docs do not indicate what negative value means?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions