-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate to using uv for build system #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d1bf9f8
to
e9f8c21
Compare
ehildenb
commented
Apr 29, 2025
tothtamas28
reviewed
Apr 29, 2025
tothtamas28
approved these changes
Apr 29, 2025
automergerpr-permission-manager bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
- A small fix to an error in the `sed` expression introduced here: #537 --------- Co-authored-by: devops <[email protected]> Co-authored-by: Everett Hildenbrandt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working on migrating our build systems to use
uv
instead ofpoetry
, as it's a more modern/faster/shinier thing.See here for more reasoning: runtimeverification/kontrol#1011
This largely follows that PR for making the migration, but skips all the Nix flake as my understanding is none of that is working in this repo at the moment anyway.
In addition, the
Dockerfile
setup is adjusted to not run asroot
on CI, to make sure it's more similar to an actual user's environment.