Add hooks for BLS12-381 #213
Conversation
virgil-serbanuta
force-pushed
the
virgil/add-bls12-hooks
branch
from
a4805c4 to
a023095
Compare
|
These should have test vectors added like the following: https://github.com/runtimeverification/blockchain-k-plugin/blob/master/krypto/src/tests/integration/test_ecdsa.py (for each function that is added as a hook). This is to ensure that each of these hooks is wired up properly and producing the outputs expected when calling into the external library. Ideally the test-vectors are sourced from somewhere else (so we know they're correct), but even auto-filling them is OK too. |
Added tests. Most of them have comments pointing to their origin. For some of them I didn't find existing tests. |
| (BLS12_G2_INFTY, 2**256 - 1, BLS12_G2_INFTY, 'max_scalar_times_inf'), | ||
| (BLS12_G2, 0, BLS12_G2_INFTY, 'zero_times_generator'), | ||
| (BLS12_G2, 1, BLS12_G2, 'one_times_generator'), | ||
| # (BLS12_G2, BLS12_Q, BLS12_G2_INFTY, 'q_times_generator'), |
There was a problem hiding this comment.
Is this left out on purpose?
There was a problem hiding this comment.
No, I remove it.
|
LGTM as well, thanks for adding tests. I checked that they're run on CI. |
automergerpr-permission-manager
bot
merged commit 5341429
into
runtimeverification:master
|
Thanks for the review! |
Here is the (Pi2) EVM PR that uses this:
Pi-Squared-Inc/evm-semantics#42