avm: Fix issues with parsing "inf" floats on nightly Rust #3984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herschel
force-pushed
the
nightly-num-parse
branch
from
7472e9a to
0f9fefa
Compare
Rust nightly 4/13 allows f64::parse to handle "infinity", case
insensitive. This broke cases such as `Number("Infinity")`, which
should return `NaN` in AVM1.
Additionally, Rust will now print "-0" for negative zero, when
previously it would print "0".
* Return NaN for inf cases ("inf", "-Infinity", "+INF", etc.)
* Add a test for `Number("inf")` (this was also incorrect before
the latest nightly)
* Add a special case for zero in `f64_to_string` to ensure
that -0.0 gets coerced to "0".
For more info, see:
rust-lang/rfcs#1074
Herschel
force-pushed
the
nightly-num-parse
branch
from
0f9fefa to
800bb58
Compare
Herschel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust nightly 4/13 allows f64::parse to handle "infinity", case
insensitive. This broke cases such as
Number("Infinity"), whichshould return
NaNin AVM1. Also,Number("inf")incorrectlyreturned
Infinityin both AVM1 and AVM2.Additionally, Rust will now print "-0" for negative zero, when
previously it would print "0".
Number("inf")(this was also incorrect beforethe latest nightly)
f64_to_stringto ensurethat -0.0 gets coerced to "0".
For more info, see:
rust-lang/rfcs#1074