Skip to content

parser pull: Add support for reusing parser #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/rexml/parsers/baseparser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,10 @@ def add_listener( listener )

def stream=( source )
@source = SourceFactory.create_from( source )
reset
end

def reset
@closed = nil
@have_root = false
@document_status = nil
Expand Down
4 changes: 4 additions & 0 deletions lib/rexml/parsers/pullparser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ def pull
def unshift token
@my_stack.unshift token
end

def reset
@parser.reset
end
end

# A parsing event. The contents of the event are accessed as an +Array?,
Expand Down
33 changes: 33 additions & 0 deletions test/test_pullparser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,39 @@ def test_peek
assert_equal( 0, names.length )
end

def test_reset
xml_chunks = [
"<message>First valid and complete message</message>",
"<message>Second valid and complete message</message>",
"<message>Third valid and complete message</message>"
]

messages = []

IO.pipe do |reader, writer|
xml_chunks.each do |chunk|
writer.write(chunk)
end
writer.close

parser = REXML::Parsers::PullParser.new(reader)
while parser.has_next?
parser.pull
message_text = parser.pull
messages << message_text[0]
parser.pull
parser.reset
end
end

assert_equal(
messages,
["First valid and complete message",
"Second valid and complete message",
"Third valid and complete message"]
)
end

class EntityExpansionLimitTest < Test::Unit::TestCase
class GeneralEntityTest < self
def test_have_value
Expand Down