Add Ruby 2.5.4 sources #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in <ruby/ruby@63d9ab3> added a new member to `struct rb_vm_struct` in vm_core.h, which means that using `ruby-2.5.1-p57` headers (the only ones in the gem) for Ruby 2.5.4+ can result in incorrect code. I've ran into this during my work on @DataDog 's [ddtrace](https://github.com/DataDog/dd-trace-rb) gem, which uses `debase-ruby_core_source`.
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
May 13, 2022
Hopefully ruby-debug/debase-ruby_core_source#6 will be merged upstream soon.
|
Thank you! |
|
Thanks a lot for picking this up! 😄 |
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
May 18, 2022
Hopefully ruby-debug/debase-ruby_core_source#6 will be merged upstream soon.
ivoanjo
added a commit
to DataDog/dd-trace-rb
that referenced
this pull request
May 24, 2022
Hopefully ruby-debug/debase-ruby_core_source#6 will be merged upstream soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in ruby/ruby@63d9ab3
added a new member to
struct rb_vm_structin vm_core.h, which means that usingruby-2.5.1-p57headers (the only ones in the gem) for Ruby 2.5.4+ can result in incorrect code.I've ran into this during my work on @DataDog's ddtrace gem, which uses
debase-ruby_core_source.Would be awesome to get this included in the gem! Let me know if I can provide any more info or fix anything that I did wrong :)