Consolidate use of single ByteBufAllocator exposed from the transport
#796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that Transport setups and provides access to Allocator where the RSocketRequester/RSocketResponder may get access to set up allocator over DuplexConnection#alloc method Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
changed the title
ByteBufAllocator is used
OlegDokuka
changed the title
ByteBufAllocator is usedByteBufAllocator is used and setup
OlegDokuka
added
enhancement
refactorings
rstoyanchev
reviewed
Apr 24, 2020
There was a problem hiding this comment.
Looks good.
I'm tempted to say we remove byteBufAllocator from RSocketConnector and RSocketServer altogether and clean up. The methods on RSocketFactory would be documented as "deprecated and no longer used".
It is unlikely this is used and the only potential impact would be use of heap buffers and only for things above the transport level. Given all the related effort to clean up leaks it seems reasonable to me to take this step.
WDYT?
|
Yeah, I'm up! |
Signed-off-by: Oleh Dokuka <[email protected]>
Signed-off-by: Oleh Dokuka <[email protected]>
rstoyanchev
changed the title
ByteBufAllocator is used and setupByteBufAllocator exposed from the transport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that Transport setups and provides access to Allocator whereas the RSocketRequester/RSocketResponder may get access to set up allocator over DuplexConnection#alloc method
Signed-off-by: Oleh Dokuka [email protected]