-
Notifications
You must be signed in to change notification settings - Fork 80
Add Field Descriptor Deserialization Logic #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Field Descriptor Deserialization Logic #335
Conversation
Why have you created a second PR that overlaps with #334? Isn't this introducing the same changes? |
I felt the previous pr failed , became really messy and confusing so created a new pr which only have right now field descriptor logic then in the future pr I will add rest of the logic taking the #334 pr as help |
In general it's not great to "restart fresh" with PRs because you lose track of all comments and history of changes. In this case it may work because the amount of code changes is small, but still there are 4 or 5 comments of mine on the old PR which still need to be addressed. |
Okay, Thankyou so much for telling me this .I will keep this in mind in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor things before merging
@silverweed this >>> is givinng error , I think Javascript throws error when we use >>> on BigInt Numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR adds the logic to read field descriptors from the RNTuple header. It includes:
However, there's an issue: the code throws an offset out of bounds error while reading. I've tried multiple approaches but haven’t been able to debug the reason of error yet.