[WIP] Support for laravel 5.6 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 5, 2018 11:47
* Changed php support to min of >=7.1 as per laravel 5.6
* Changed reqiured dependancy `illuminate/support` to minimum ^5.0
* Added local docker `phpunit`, `phpunit-versions`, `composer` helpers `./bin/`
- e.g. simply type `bin/phpunit`
* Updated travis config
* Use of class constants to add coverage of namespace collision edge cases
* Added config helper to DRY codebase
* Added basic method return type declarations (strong typing is a win:win)
|
See readme for some small docker changes |
|
@andrewmclagan great PR. Thank you for your work on this. I will definitely use it as soon as I figure out the best way to fit this into our tagging policy. |
|
This has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a proposal to migrate some core changes and support php7 / larave 5.6 on a new
3.x.xtagging moving forward and older versions on the2.x.xtagging:5.6.xilluminate/supportto minimum ^5.0phpunit,phpunit-versions,composerhelpers./bin/bin/phpunit6.x.x