Skip to content

ConnectivityMonitor tests wrong thing #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pbiggar opened this issue Feb 7, 2022 · 1 comment · Fixed by #621
Closed

ConnectivityMonitor tests wrong thing #615

pbiggar opened this issue Feb 7, 2022 · 1 comment · Fixed by #621
Assignees
Labels
bug Denotes a runtime problem within the SDK

Comments

@pbiggar
Copy link

pbiggar commented Feb 7, 2022

The ConnectivityMonitor is required for queued events to be sent to the API. Before an event is sent, the ConnectivityMonitor checks if the internet is available.

However, it checks www.rollbar.com on port 80, not api.rollbar.com on port 443, which is what's required to send to the API.

For servers on which port 80 is blocked, the ConnectivityMonitor reports that the server is offline. However, in my case, the server is perfectly capable of reaching https://api.rollbar.com.

As further issues, the ConnectivityMonitor is not covered in the documentation - I had to search the codebase for the error I was experiencing and read the code to discover the issue.

Finally, it seems that while I can reach the ConnectivityMonitor via Rollbar.RollbarInfrastructure.Instance.ConnectivityMonitor, I don't seem to be able to call the Disable method on it, as that returns an IConnectivityMonitor.

@akornich akornich self-assigned this Feb 7, 2022
@akornich akornich added the bug Denotes a runtime problem within the SDK label Feb 7, 2022
@akornich
Copy link
Contributor

@pbiggar , thanks for catching it.
I'll be fixing it shortly.
I'll also add public access to Rollbar.RollbarInfrastructure.Instance.ConnectivityMonitor?.Disable()

akornich added a commit to WideSpectrumComputing/Rollbar.NET that referenced this issue Feb 10, 2022
akornich added a commit that referenced this issue Feb 10, 2022
fix: resolve GH #615 - ConnectivityMonitor tests wrong thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Denotes a runtime problem within the SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants