Skip to content

Access point fixes #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2020
Merged

Access point fixes #137

merged 3 commits into from
May 30, 2020

Conversation

rjwats
Copy link
Owner

@rjwats rjwats commented May 29, 2020

add lingering mode to access point
fix bug which prevents active access point from being re-configured

@kasedy
Copy link
Contributor

kasedy commented May 30, 2020

nit: I prefer ApProvisionMode over APProvisionMode

Is it possible to add a tooltip over the status icon to indicate that AP point may stay active while users are connected. Reset the device to drop users and disable AP point.

@rjwats
Copy link
Owner Author

rjwats commented May 30, 2020

Yes. I prefer the "ApProvisionMode" naming style too - it avoids the possiblity of silly names like APHTTPEndpoint.

The underlying libaries obviously don't all adher to a single naming convention: such as FS, ArduinoOTAClass and the 'softAPgetStationNum()' and 'softAPIP()' functions. My brain hates the inconsistancy within a class more than it cares about my preferred naming style so I choose to carry the underlying naming through :) (but yeah - boo for upper case acronyms.)

@rjwats rjwats merged commit 555b3ef into master May 30, 2020
@rjwats rjwats deleted the ap-fixes2 branch May 30, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants