Fix panic on RUST_LOG=<filter> during tests #1154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It doesn't seem like this is related to |
…om/risc0/risc0 into cardosaum/hotfix/test-log-features
Cardosaum
changed the title
Cardosaum
requested review from
flaub and
SchmErik
and removed request for
flaub
flaub
reviewed
Nov 29, 2023
| @@ -14,7 +14,8 @@ tracing = { version = "0.1", features = ["log"] } | |||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | |||
|
|
|||
| [dev-dependencies] | |||
| test-log = { version = "0.2", default-features = false, features = ["trace"] } | |||
| env_logger = "0.10" | |||
| test-log = { version = "0.2", features = ["trace", "log"] } | |||
There was a problem hiding this comment.
The default already contains log
Suggested change
| test-log = { version = "0.2", features = ["trace", "log"] } | |
| test-log = { version = "0.2", features = ["trace"] } |
SchmErik
reviewed
Nov 29, 2023
| @@ -8,8 +8,9 @@ homepage = { workspace = true } | |||
| repository = { workspace = true } | |||
|
|
|||
| [dev-dependencies] | |||
| env_logger = "0.10" | |||
There was a problem hiding this comment.
why is both env_logger and tracing subscriber a part of this? I thought that we only needed tracing and tracing-subscriber
|
I found the underlying issue that some of us have run into, it's likely because we were using an older version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR to address a bug report encountered when running a test with
RUST_LOG=info. The bug causes a panic due to a regex parse error related to Unicode-aware case insensitivity matching - exactly like the issue described in tracing-subscriber. I have tried to fix it by specifyingtest-logfeature to bothlogandtracein theCargo.tomlfile.I can't validate the fix on my machine yet, since this seems to arise only when
-F cudais passed, and I don't have the required hardware to test it.