Fix crash on missing dev dependency #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrolich
reviewed
May 5, 2025
| @@ -33,51 +33,57 @@ fi | |||
| node ./packages/main/src/Main.mjs > ./packages/main/src/output.txt | |||
|
|
|||
| mv ./packages/main/src/Main.res ./packages/main/src/Main2.res | |||
| rewatch build --no-timing=true &> ../tests/snapshots/rename-file.txt | |||
jfrolich
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like mentioned in #124 (comment) there is a case where dependencies are listed in
bs-dev-dependenciesbut can not be found in the file system. For example in@rescript/corethe dev dependency@rescript/toolsis not included in the final npm package.This PR fixes this issue by ignoring missing dev deps. It is still an error for non dev deps.
This matches the behavior of
bsbwhen I tried it on thetestrepo.