-
Notifications
You must be signed in to change notification settings - Fork 470
Add @notUndefined attribute to more Stdlib abstract types #7464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
Thanks, that's great! Would you mind looking through all the stdlib/runtime files and extending this PR accordingly? |
@fhammerschmidt should we document this attribute as well? |
Could be useful for library authoes at least. So yes. |
@cknitt I've updated the PR to also add the attribute to any other abstract types I could find in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! 🎉
Adds the
@notUndefined
attribute to:Map.t
Set.t
WeakMap.t
WeakSet.t
Stdlib_Intl_*
Stdlib_AsyncIterator
Stdlib_Iterator
Stdlib_DataView
Stdlib_ArrayBuffer
Stdlib_JsError
Stdlib_Symbol
Stdlib_TypedArray