Skip to content

Do not error on ref as prop #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2025
Merged

Do not error on ref as prop #7420

merged 2 commits into from
May 4, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 4, 2025

ref as prop is now allowed in React 19, see https://react.dev/blog/2024/12/05/react-19#ref-as-a-prop

@cknitt cknitt requested a review from fhammerschmidt May 4, 2025 15:53
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 4, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7420

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7420

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7420

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7420

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7420

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7420

commit: 9d03c2b

@cknitt cknitt merged commit 80c96a1 into master May 4, 2025
21 checks passed
@cknitt cknitt deleted the jsx-no-ref-check branch May 4, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cknitt @zth @fhammerschmidt