Skip to content

Move all dune/ocaml config files into the compiler folder #7091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 7, 2024

Further cleanup of the project root. All the OCaml stuff is under compiler, so we can also move dune-project, rescript.opam etc. there.

Downside is that you need to cd to the compiler dir to be able to run dune build.

make still works from the project root though.

@cknitt cknitt force-pushed the cleanup-ocaml-files branch from 77cae02 to b3b2948 Compare October 7, 2024 14:32
@cknitt cknitt force-pushed the cleanup-ocaml-files branch from b3b2948 to 49cbe86 Compare October 8, 2024 05:27
@cknitt cknitt marked this pull request as ready for review October 8, 2024 06:48
@cknitt cknitt requested review from cristianoc and zth October 8, 2024 06:50
@cknitt cknitt merged commit 5781b4e into rescript-lang:master Oct 8, 2024
20 checks passed
@cknitt cknitt deleted the cleanup-ocaml-files branch October 8, 2024 07:35
cknitt added a commit to cknitt/rescript that referenced this pull request Oct 9, 2024
cknitt added a commit that referenced this pull request Oct 9, 2024
…7093)

* Revert "Fix syntax roundtrip tests (#7092)"

This reverts commit 0e02681.

* Revert "Move all dune/ocaml config files into the compiler folder (#7091)"

This reverts commit 5781b4e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants