Remove rescript convert subcommand

CHANGELOG.md

@@ -30,6 +30,7 @@
 - Some global names and old keywords are no longer prefixed. https://github.com/rescript-lang/rescript-compiler/pull/6831
 - Remove ml parsing tests and conversion from `.ml` to `.res` via format. https://github.com/rescript-lang/rescript-compiler/pull/6848
 - Remove support for compiling `.ml` files, and general cleanup. https://github.com/rescript-lang/rescript-compiler/pull/6852
+- Remove `rescript convert` subcommand. https://github.com/rescript-lang/rescript-compiler/pull/6860
 
 #### :bug: Bug Fix
 

cli/rescript_bsb.js

@@ -322,10 +322,7 @@ Please pick a different one using the \`-ws [host:]port\` flag from bsb.`);
     if (!fileName) return true;
 
     return (
-      ((fileName.endsWith(".res") ||
-        fileName.endsWith(".resi") ||
-        fileName.endsWith(".ml") ||
-        fileName.endsWith(".mli")) &&
+      ((fileName.endsWith(".res") || fileName.endsWith(".resi")) &&
         !watchGenerated.includes(fileName)) ||
       fileName === resConfig
     );

jscomp/build_tests/cli_help/input.js

@@ -16,7 +16,6 @@ const cliHelp =
   "  build\n" +
   "  clean\n" +
   "  format\n" +
-  "  convert\n" +
   "  dump\n" +
   "  help\n" +
   "\n" +
@@ -58,17 +57,6 @@ const formatHelp =
   "  -all    Format the whole project \n" +
   "  -check  Check formatting for file or the whole project. Use `-all` to check the whole project\n";
 
-const convertHelp =
-  "Usage: rescript convert <options> [files]\n" +
-  "\n" +
-  "`rescript convert` converts the current directory\n" +
-  "\n" +
-  "**This command removes old OCaml files and creates new ReScript \n" +
-  "files. Make sure your work is saved first!**\n" +
-  "\n" +
-  "Options:\n" +
-  "  -all  Convert the whole project\n";
-
 const dumpHelp =
   "Usage: rescript dump <options> [target]\n" +
   "`rescript dump` dumps the information for the target\n";
@@ -232,26 +220,6 @@ async function test() {
     assert.equal(out.status, 0);
   }
 
-  {
-    // Shows convert help with --help arg
-    const out = await exec(`../../../rescript`, ["convert", "--help"], {
-      cwd: __dirname,
-    });
-    assert.equal(out.stdout, convertHelp);
-    assert.equal(out.stderr, "");
-    assert.equal(out.status, 0);
-  }
-
-  {
-    // Shows convert help with -h arg
-    const out = await exec(`../../../rescript`, ["convert", "-h"], {
-      cwd: __dirname,
-    });
-    assert.equal(out.stdout, convertHelp);
-    assert.equal(out.stderr, "");
-    assert.equal(out.status, 0);
-  }
-
   {
     // Shows dump help with --help arg
     const out = await exec(`../../../rescript`, ["dump", "--help"], {

packages/artifacts.txt

@@ -8,7 +8,6 @@ bsc
 cli/bin_path.js
 cli/rescript_arg.js
 cli/rescript_bsb.js
-cli/rescript_convert.js
 cli/rescript_dump.js
 cli/rescript_format.js
 cli/rescript_postinstall.js

rescript

@@ -36,7 +36,6 @@ Subcommands:
   build
   clean
   format
-  convert
   dump
   help
 
@@ -119,14 +118,6 @@ if (helpArgIndex !== -1 && (firstPositionalArgIndex === -1 || helpArgIndex <= fi
       );
       break;
     }
-    case "convert": {
-      require("./cli/rescript_convert.js").main(
-        subcmdArgs,
-        rescript_exe,
-        bsc_exe
-      );
-      break;
-    }
     default: {
       console.error(
         `Error: Unknown command "${subcmd}".\n${helpMessage}`