Skip to content

Turn off transformation for closures inside loops. #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2024

Conversation

cristianoc
Copy link
Collaborator

The scope of var is per-function, requiring a transformation for closures inside loops when capturing loop variables. This PR turns off the transformation.
This PR should go after #6102

@cristianoc cristianoc added this to the v12 milestone Nov 9, 2023
@cristianoc cristianoc force-pushed the no_closure_inside_loop branch from fa2d150 to 9491fd9 Compare November 9, 2023 09:40
@cristianoc cristianoc changed the base branch from master to let November 9, 2023 09:41
@cristianoc
Copy link
Collaborator Author

Tests look fine after rebasing on top of #6102

@cristianoc cristianoc force-pushed the let branch 4 times, most recently from 075719b to c52d009 Compare April 30, 2024 08:35
@cristianoc cristianoc force-pushed the no_closure_inside_loop branch from 9491fd9 to 10fd84f Compare April 30, 2024 12:17
@cristianoc cristianoc changed the base branch from let to master April 30, 2024 12:17
@cristianoc cristianoc force-pushed the no_closure_inside_loop branch from 10fd84f to 9906f19 Compare April 30, 2024 12:21
The scope of `var` is per-function, requiring a transformation for closures inside loops when capturing loop variables.
This PR turns off the transformation.
@cristianoc cristianoc force-pushed the no_closure_inside_loop branch from 9906f19 to 1f8af1b Compare April 30, 2024 12:23
@cristianoc cristianoc requested a review from cknitt April 30, 2024 12:23
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cknitt cknitt merged commit cfed01f into master May 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants