Skip to content

[Bsb] Revert the React template from es6 to commonjs #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2018
Merged

[Bsb] Revert the React template from es6 to commonjs #2617

merged 2 commits into from
Mar 13, 2018

Conversation

chenglou
Copy link
Member

@chenglou
Copy link
Member Author

cc @thangngoc89 @glennsl

thangngoc89
thangngoc89 reviewed Mar 13, 2018
View reviewed changes
jscomp/bsb/templates/react/README.md Outdated
@@ -20,3 +20,5 @@ npm run webpack:production
```

This will replace the development artifact `build/Index.js` for an optimized version.

**To enable dead code elimination**, change `bsconfig.json`'s `package-specs` `module` from `"commonjs"` to `"es6"`. Then re-run the above 2 commands. This will allow weback to remove unused code.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weback => webpack

@chenglou chenglou merged commit 38b7386 into rescript-lang:master Mar 13, 2018
@chenglou chenglou deleted the react branch March 13, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thangngoc89 thangngoc89 thangngoc89 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenglou @thangngoc89