-
Notifications
You must be signed in to change notification settings - Fork 60
Attributes not included in reanalyze locations #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
cristianoc
added a commit
to rescript-lang/rescript
that referenced
this issue
May 29, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
cristianoc
added a commit
to rescript-lang/rescript
that referenced
this issue
May 29, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
This happens to be due to an issue in the parser: rescript-lang/rescript#6791 |
cristianoc
added a commit
to rescript-lang/rescript
that referenced
this issue
May 29, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
Fixed in compiler master. |
cknitt
pushed a commit
to rescript-lang/rescript
that referenced
this issue
Jun 15, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
cknitt
pushed a commit
to rescript-lang/rescript
that referenced
this issue
Jun 16, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
cknitt
pushed a commit
to rescript-lang/rescript
that referenced
this issue
Jun 16, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
cknitt
pushed a commit
to rescript-lang/rescript
that referenced
this issue
Jun 16, 2024
The location of let bindings did not include annotations attached to the binding (for the first binding in a sequence). This would show up in actions for dead code elimination in the editor tooling, which would remove everything but the annotation: rescript-lang/rescript-vscode#991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cc @cristianoc
Example:
@react.component
that's unused@react.component
is removedThe text was updated successfully, but these errors were encountered: