Render React in playground #869
Conversation
|
@tsnobip is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
tsnobip
force-pushed
the
react_output_in_playground
branch
from
6639afe to
301e587
Compare
|
Do you think the react deps should be listed here as well? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I don't think so, those are ReScript dependencies. |
|
I'm actually wondering if a Console panel is that much needed, one could just open the console of the browser and have a better rendering of the logs, what do you guys think? |
|
I would keep the Console tab but maybe we can have a hybrid of both Rendering and Console. In practice you most often want to have either Console or HTML, only more convoluted examples may have both. |
|
That's an interesting idea, we could do that in a follow-up PR. We could use "output" as the name of this tab. |
|
Why would we want to add a new tab now only to remove it again later? Let's just add it here. Or hide it and only reveal it in the next PR. |
|
Well to be honest I'm not sure of what's the best solution here, I'm a bit afraid that having to switch between the "output" tab and the console tab of your browser might be a bit confusing too, what about asking in the forum maybe? edit: done here https://forum.rescript-lang.org/t/output-of-the-code-run-in-the-playground/5269 |
|
@fhammerschmidt can you take a look, in the last commit I shipped the "Output" layout, there's the react panel first then the console output. Let me know if you prefer this. To be honest, I still think we should rather use the built-in browser dev console for the console output. |
|
this got merged in #875 🎉 |
Now ready for review @fhammerschmidt :)