Skip to content

Install needed folders for snapshot #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ulrikstrid
Copy link

This allows us to skip submodule checkout in git. I'm opening a companion PR on bucklescript/bucklescript as well.

cristianoc added a commit to rescript-lang/rescript that referenced this pull request Nov 3, 2019
@bobzhang bobzhang requested a review from cristianoc November 4, 2019 01:56
@bobzhang
Copy link
Member

bobzhang commented Nov 4, 2019

LGTM, @cristianoc can you confirm it works?

@cristianoc
Copy link

@bobzhang I have abandoned this for now:
rescript-lang/rescript#3910

@ulrikstrid
Copy link
Author

This works to build under Windows with esy now. I had to remove flexdll and use a special esy version instead, does this break the normal flow, if it does I can probably get the script to remove the current flexdll instead.

I can add the Azure Pipelines that are normally in esy-ocaml to make sure that this works @bobzhang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants