Update FetchAPI constructors #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
May 21, 2025
src/FetchAPI/HeadersInit.res
Outdated
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#setting_headers) | ||
| */ | ||
| external fromKVArray: array<(string, string)> => headersInit = "%identity" |
There was a problem hiding this comment.
Suggested change
| external fromKVArray: array<(string, string)> => headersInit = "%identity" | |
| external fromKeyValueArray: array<(string, string)> => headersInit = "%identity" |
src/FetchAPI/URLSearchParams.res
Outdated
|
|
||
| /** | ||
| [Read more on MDN](https://developer.mozilla.org/docs/Web/API/URLSearchParams) | ||
| */ | ||
| @new | ||
| external make2: (~init: any=?) => urlSearchParams = "URLSearchParams" | ||
| external fromKVArray: array<(string, string)> => urlSearchParams = "URLSearchParams" |
There was a problem hiding this comment.
Suggested change
| external fromKVArray: array<(string, string)> => urlSearchParams = "URLSearchParams" | |
| external fromKeyValueArray: array<(string, string)> => urlSearchParams = "URLSearchParams" |
tests/FetchAPI/Headers__test.res
Outdated
|
|
||
| let h2 = Headers.fromDict(dict{"X-Vegetable": "Carrot"}) | ||
|
|
||
| let h3 = Headers.fromKVArray([("X-Fruit", "Apple"), ("X-Vegetable", "Carrot")]) |
There was a problem hiding this comment.
Suggested change
| let h3 = Headers.fromKVArray([("X-Fruit", "Apple"), ("X-Vegetable", "Carrot")]) | |
| let h3 = Headers.fromKeyValueArray([("X-Fruit", "Apple"), ("X-Vegetable", "Carrot")]) |
| params1->URLSearchParams.keys->Iterator.toArray->Array.forEach(Console.log) | ||
|
|
||
| let params2 = URLSearchParams.make3(~init="?foo=1&bar=b") | ||
| let params2 = URLSearchParams.fromKVArray([("foo", "1"), ("bar", "b")]) |
There was a problem hiding this comment.
Suggested change
| let params2 = URLSearchParams.fromKVArray([("foo", "1"), ("bar", "b")]) | |
| let params2 = URLSearchParams.fromKeyValueArray([("foo", "1"), ("bar", "b")]) |
|
Thanks for your suggestion! |
|
How is |
Hmm, you are suggesting to maybe reuse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.